search

RoccoC / webpack-build-notifier

A Webpack plugin that generates OS notifications for build steps using node-notifier.
MIT License
162 stars 24 forks source link

webpacks's `ignoreWarnings` is not used #90

Closed ImLunaHey closed 3 months ago

ImLunaHey commented 11 months ago

I noticed I'm still getting notifications for warnings that're being filtered by webpack's ignoreWarnings field. 🤔

nolimitdev commented 4 months ago

The same problem here :( Also webpack-build-notifier does not support messages filtering to omit it.

RoccoC commented 4 months ago

There's an open PR to fix this, but IIRC tests are failing. Happy to merge it in once the issues there are fixed! 🙏 cc: @ImLunaHey

ImLunaHey commented 3 months ago

this has been working in production for a while now. which tests aren't passing?

RoccoC commented 3 months ago

Fixed in #91 and #92.

Drumstix42 commented 3 months ago

In my configuration, to use v3.0.0, I needed to update my import from this:

const WebpackBuildNotifierPlugin = require('webpack-build-notifier');

to:

const WebpackBuildNotifierPlugin = require('webpack-build-notifier').default

Is that expected?

RoccoC commented 3 months ago

Is that expected?

No, it isn't. Looks like this is because of how tsup bundles commonjs. Let me get this fixed...

RoccoC commented 3 months ago

@Drumstix42 , this is fixed in 3.1.0. Thanks for bringing it to my attention!

nolimitdev commented 3 months ago

Confirming that issue is fixed. Thanks all! Great job!