search

Rochet2 / TrinityCore

Rochet2's stuff for TC
https://rochet2.github.io
90 stars 143 forks source link

Reforging removes resilience #100

Closed Duratans closed 5 years ago

Duratans commented 5 years ago

Description:

pvp items when reforging loose resilience stats

Current behavior:

equip any item with resilience , reforge it, that item resilience stats will be deducted from your total resilience

Expected behavior:

the stats should change resilience should not

Steps to reproduce the problem:

equip any item with resilience , reforge it, that item resilience stats will be deducted from your total resilience

latest pull

Rochet2 commented 5 years ago

Can you post an example of an item (item entries)? I cannot reproduce it:

wow_2019-01-22_22-52-29 wow_2019-01-22_22-51-45 wow_2019-01-22_22-52-21 wow_2019-01-22_22-52-42 wow_2019-01-22_22-53-01 wow_2019-01-22_22-57-14

Duratans commented 5 years ago

I just tried creating a fresh character, resilience is still being deducted. I tried doing a test, i tested on the direct merge branch and it works fine,. applying the patch yourself creates this problem., Also maybe Transmog and Reforger are not compatible together?

Rochet2 commented 5 years ago

applying the patch yourself creates this problem

this would mean that the patch was applied wrong.

Also maybe Transmog and Reforger are not compatible together?

maybe, but that is unlikely the case as they do not really edit the same things. Maybe I will test that, but it will likely not be the reason.

Duratans commented 5 years ago

The patch was not applied wrong, this is not a big patch. i successfully applied your Transmog Patch manually without an issues, reforge npc is a very easy apply unless the diff we used to apply the patch doesn't work.

Rochet2 commented 5 years ago

Currently I do not know the item entry you use, if the item was transmogrified or not and if it was then what was it transmogrified to look like, what stats you reforged into what other stats. Could you post this information, so I know more about what you did.

Then I can try to apply both patches locally and test the scenario you have. If I am able to reproduce it I will then be able to also debug it and possibly fix it or better understand what is causing it.

Duratans commented 5 years ago

I ma simply creating a new character, adding myself a random Season8 item that has resilience and trying every single option available on the item i have equipped. No matter what stats i change resilience is gone. I am not trasnmogin the item or doing anything to the item,

Rochet2 commented 5 years ago

Cannot reproduce still.

I had the legs and hands equipped for warrior. Here is the patch I used. It contains reforging and transmogrification: https://gist.github.com/Rochet2/5af87dc1b2f53800207109ca25486a37

Status before reforging:

wow_2019-01-24_18-07-48 wow_2019-01-24_18-09-43 wow_2019-01-24_18-06-22

Status after reforging:

wow_2019-01-24_18-07-48 wow_2019-01-24_18-07-39 wow_2019-01-24_18-13-04

Duratans commented 5 years ago

I applied the patch that has both in it, and worked perfect thank you