search

Rochet2 / TrinityCore

Rochet2's stuff for TC
https://rochet2.github.io
90 stars 143 forks source link

When you release spirit, mobs will aggro onto your ghost prior to being teleported to the graveyard. #101

Closed Duratans closed 5 years ago

Duratans commented 5 years ago

https://github.com/TrinityCore/TrinityCore/commit/28591fd1658e3e4842d64f330f27c233dc69aad2

Needs to be ported to these branches, present behavior is still bugged as it explains here:

Description:

For some reason, if you release your spirit close to a mob that can aggro onto you, the mob will aggro for a split second and reset. This can be seen easily on boss encounters where you would normally die close to the boss home position. Not necessarily any "negative" issues related to this that I have noticed so far, but definitely not working as intended.

Current behavior:

When you release spirit, mobs will aggro onto your ghost prior to being teleported to the graveyard.

Expected behavior:

Mobs should not aggro onto your ghost when releasing.

Steps to reproduce the problem:

Die close to a mob that can aggro onto you, easily seen on raid bosses Release spirit while observing creature behavior from a second account Branch(es): 3.3.5 multivendor

Rochet2 commented 5 years ago

The bug does not seem to be related to multivendor ( or any other scripts on this repository ). If this is a bug related to trinitycore, report it on trinitycore repository https://github.com/TrinityCore/TrinityCore/issues.

Also do note that you should be using multivendor_3.3.5 branch and not multivendor branch, in case you are still using the latter one.

Duratans commented 5 years ago

It was already fixed on trinitycore? i am asking you to port the changes to your branches, this has nothing to do with Multivendor branch, it's the trinitycore issue and since multivendor runs on trinitycore i am requesting you to port the changes. this was already fixed on trinityciore i am reporting it here so you can do the merge. since it's still bugged here.

Duratans commented 5 years ago

https://github.com/TrinityCore/TrinityCore/commit/28591fd1658e3e4842d64f330f27c233dc69aad2

Rochet2 commented 5 years ago

It has been merged for months, as you can see that the changes can be found in the code: https://github.com/Rochet2/TrinityCore/blob/multivendor_3.3.5/src/server/game/Entities/Player/Player.h#L668 https://github.com/Rochet2/TrinityCore/blob/multivendor_3.3.5/src/server/game/Handlers/MovementHandler.cpp#L46 I am not sure how you expect me to port the changes if they are already there. TC is merged into the branches every day, so a change from months ago should be there.

If we compare multivendor to regular TC, we can see that the only code added is just the multivendor code, so no TC code is added or removed, so the fix should be there. diff

Maybe you just dont have the code pulled on your local installation. Pulling either multivendor_3.3.5 or TrinityCore 3.3.5 should fix the issue for you.

Duratans commented 5 years ago

I am sorry Rochet, But i am only here to report something.. I have 3 different cores, one of them is yours, on Original Trinity Branch, this problem is no longer there. That is why i even asked.