search

Rochet2 / TrinityCore

Rochet2's stuff for TC
https://rochet2.github.io
90 stars 143 forks source link

Player & Item Gossip #119

Closed src893 closed 3 years ago

src893 commented 4 years ago

Script not compatible with latest trinitycore build and latest gossip system

Rochet2 commented 4 years ago

How is it not compatible? Do you talk about 3.3.5 or master? Travis shows it merges and builds fine on both: https://travis-ci.org/github/Rochet2/TrinityCore3.3.5/jobs/696861865 https://travis-ci.com/github/Rochet2/TrinityCoremaster/jobs/346889891

SlntHntr commented 4 years ago

Been having a similar issue lately. Have used your transmog in the past but lately it's hanging up with overrides on the build. Specifically in the gossiphelper if I recall. Will attempt a rebuild and post more detailed info this evening after work.

Did a quick look at some error logs I found - could be another mod causing the conflict. Scrap my ramblings ;) Will do a double check tonight but I believe my issue is with NPCBots, Core, and Transmog being happy together.

Raven-dku commented 4 years ago

That's still an issue. Treeston's pull request fixed few errors, but GossipHello/OnGossipHello is going wild with overrides.

Rochet2 commented 3 years ago

I assume this is fixed since CI now passes. Comment back or open a new ticket if still not resolved.