Rochet2 / TrinityCore

Rochet2's stuff for TC
https://rochet2.github.io
89 stars 144 forks source link

Unable to apply transmogs to 1H sword #132

Closed dabeer closed 3 years ago

dabeer commented 3 years ago

Description: Unable to apply transmog to 1H sword

Current behaviour:

Equipped new Avool's Sword of Jin (1H sword) in MH slot, with new The Black Knight (1H sword) in inventory. Talked to transmog vendor, menu option to apply transmog was not presented. Reversed, with The Black Knight equipped and Avool's Sword of Jin in inventory, still no menu item. Equipped in OH slot, repeated, same behavior observed.

Expected behaviour:

Menu option to apply The Black Knight transmog onto Avool's Sword of Jin should have been presented.

Steps to reproduce the problem:

  1. Clone TC 3.3.5, apply Transmog diff, make, install. Apply transmog vendor template to DB, add npc.
  2. Create hunter, level 80, train dual wield. additem Avool's Sword of Jin and The Black Knight. Equip Avool's Sword of Jin in MH slot.
  3. Talk to vendor. Select Main Hand. Observe no menu option for The Black Knight.

Branch(es): TC rev. hash/commit: TDB version: CHANGEME Version of the TrinityCore database Operating system: CHANGEME OS

TC> .server debug TC> TrinityCore rev. a34519bded8a+ 2021-03-02 23:11:49 +0100 (3.3.5 branch) (Unix, RelWithDebInfo, Static) Using SSL version: OpenSSL 1.1.1g FIPS 21 Apr 2020 (library: OpenSSL 1.1.1g FIPS 21 Apr 2020) Using Boost version: 1.67.0 Using MySQL version: 100505 Using CMake version: 3.11.4 Compiled on: Linux 4.18.0-240.10.1.el8_3.x86_64 Automatic database updates are enabled for the following databases: Auth, Characters, World Worldserver listening connections on port 8085 Realmlist (Realm Id: 1) configured in port 8085 VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1 MMAPs status: Enabled maps directory located in ../data/maps. Total size: 251987687 bytes vmaps directory located in ../data/vmaps. Total size: 658130721 bytes mmaps directory doesn't exist!. Using path: ../data/mmaps Using enUS DBC Locale as default. All available DBC locales: enUS Using World DB: TDB 335.21021

Rochet2 commented 3 years ago

The other item is One Hand and one item is Main Hand. You cannot transmog One Hand to Main Hand since you can equip the item to Off Hand.

You can disable this restriction in the settings. However, then it is possible to transmogrify items so that their models are the wrong way around in hands for example (main hand model in off hand). See this setting: https://github.com/Rochet2/TrinityCore/blob/ada1e6ada934a332dc08f5e1504941cf73cc0db0/src/server/worldserver/worldserver.conf.dist#L4154-L4156

dabeer commented 3 years ago

With respect - no, both items are One-Hand swords.

Rochet2 commented 3 years ago

Hmm, seems the item has changed over time or online DBs are wrong/have different info.

In any case, there are other settings that you should look into. For example, the stats count setting may be what is blocking the transformation: https://github.com/Rochet2/TrinityCore/blob/ada1e6ada934a332dc08f5e1504941cf73cc0db0/src/server/worldserver/worldserver.conf.dist#L4186-L4188

dabeer commented 3 years ago

Retried with Transmogrification.IgnoreReqStats = 1, same problem.

Also observed the problem with 2H axes, equipped Lothar's Edge and attempted to transmog to Night Reaver, and no menu option was presented. I added another epic 2H axe, Betrayer of Humanity, and the menu item to transmog Lothar to Betrayer or Betrayer to Lothar was offered, but neither one allowed Night Reaver to be applied.

The only thing I'm seeing that's consistent is that The Black Knight and Night Reaver, the items that were not offered for transmog, are both Rare, while the items to which the transmog should be applied are Epic. However, I have successfully applied Rare transmogs onto Epic items, including a 2H sword, polearm, and crossbow. I double-checked and I do have Transmogrification.AllowRare = 1.

Rochet2 commented 3 years ago

For me Transmogrification.IgnoreReqStats = 1 works just fine. I can see the black knight in the menu and transmogrify with it.

Rochet2 commented 3 years ago

make sure that the config setting is not reported missing when doing reload config.

Rochet2 commented 3 years ago

Closing for now as there is no reply