Closed ihm-tswow closed 2 years ago
Would be nice if you could test the fix. Otherwise, I will just merge it at some point after the CI tests pass.
Decided to merge already. Tested locally that dynamic build succeeds. Comment or reopen if persists.
Building TrinityCore (13f1a9f) merged with https://github.com/Rochet2/TrinityCore/tree/dressnpcs_3.3.5 with
-DSCRIPTS=dynamic
produces the following (msvc) linker error:The struct is in
DBCStructure.h
and the function inDBCStores.cpp
. Usually it's enough to addTC_GAME_API
to the struct so it exports the functions, but that doesn't seem to be enough here, and neither is moving the declaration to the other project. Leaving this issue here in case I don't find a solution any time soon.For anyone looking for a workaround, the command lookups in
cs_modify.cpp
andcs_npc.cpp
aren't critical, just comment out the calls tosCreatureDisplayInfoStore.LookupEntry