Rochet2 / TrinityCore

Rochet2's stuff for TC
https://rochet2.github.io
90 stars 143 forks source link

Transmog For Last Tc Not Work #93

Closed ghost closed 5 years ago

ghost commented 5 years ago

Hi

@Rochet2

dont work transmog for last tc 3.3.5

[ 26%] Building CXX object src/server/scripts/CMakeFiles/scripts.dir/Commands/cs_guild.cpp.o /home/TrinityCore/src/server/game/DataStores/DBCStores.cpp:115:57: error: use of undeclared identifier 'ItemDisplayTemplateEntryfmt'; did you mean 'MailTemplateEntryfmt'? DBCStorage sItemDisplayInfoStore(ItemDisplayTemplateEntryfmt); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ MailTemplateEntryfmt /home/TrinityCore/src/server/shared/DataStores/DBCfmt.h:90:16: note: 'MailTemplateEntryfmt' declared here char constexpr MailTemplateEntryfmt[] = "nxxxxxxxxxxxxxxxxxssssssssssssssssx"; ^ [ 26%] Building CXX object src/server/game/CMakeFiles/game.dir/DataStores/M2Stores.cpp.o 1 error generated. src/server/game/CMakeFiles/game.dir/build.make:1577: recipe for target 'src/server/game/CMakeFiles/game.dir /DataStores/DBCStores.cpp.o' failed make[2]: *** [src/server/game/CMakeFiles/game.dir/DataStores/DBCStores.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... [ 26%] Building CXX object src/server/scripts/CMakeFiles/scripts.dir/Commands/cs_honor.cpp.o [ 26%] Building CXX object src/server/scripts/CMakeFiles/scripts.dir/Commands/cs_instance.cpp.o [ 26%] Building CXX object src/server/scripts/CMakeFiles/scripts.dir/Commands/cs_learn.cpp.o [ 26%] Building CXX object src/server/scripts/CMakeFiles/scripts.dir/Commands/cs_lfg.cpp.o CMakeFiles/Makefile2:1197: recipe for target 'src/server/game/CMakeFiles/game.dir/all' failed make[1]: *** [src/server/game/CMakeFiles/game.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs....
ghost commented 5 years ago

@Rochet2 !?!

Rochet2 commented 5 years ago

Manually check that everything from the patch is applied exactly as is in the patch. The error suggests that you are missing ItemDisplayTemplateEntryfmt.

ghost commented 5 years ago

the last trinitycore

downloaded https://github.com/Rochet2/TrinityCore/compare/TrinityCore:3.3.5...transmog.diff

dont work, cant full builded. error

Error 2 make[1]: *** Waiting for unfinished jobs....

i use just transmog patch!

Rochet2 commented 5 years ago

Travis compiles fine. There is no indication that transmog is broken.

You must provide errors. If your errors are the same as before then make sure ItemDisplayTemplateEntryfmt is defined.

If you believe everything is fine then you must provide more data. The data is preferably the whole source. Or alternatively for example DBCStores.h, DBCStores.cpp, DBCfmt.h, DBCStructure.h if the error is still related to ItemDisplayTemplateEntryfmt.

ghost commented 5 years ago

this error is for last tc ! and transmog patch need to updated!

can u tested on last?!

Rochet2 commented 5 years ago

Tested compiling on https://github.com/TrinityCore/TrinityCore/commit/0a0312b705ecb1a318fd3abe545b571a3a349a9c here is the result: https://travis-ci.com/Rochet2/TrinityCore3.3.5/builds/89235033 Looks good to me.