Somechanges in Job Editor doesn't make JobAsset Dirty so changes aren't saved on Git

RockTomate / Issues

Submit bugs and feature requests.

4 stars 1 forks source link

Open BaalEvan opened 3 years ago

BaalEvan commented 3 years ago

Steps to Reproduce

I'm not sure which changes aren't saved because reading Yaml file of Job isn't easy to read manually, but sometimes after moving assets to another pc using git Jobs are different (not added step, different values in RunJob Input

Expected Results JobAsset should be dirtied after every change and saved automatically, to make it compatible with sourceControl

BaalEvan commented 3 years ago

Disscussed on Discord:

Save Shortcut isn't working when JobEditorWindow is selected, and there is no dirty indicator to be sure if changes are saved.

Proposed solution:

Add UI Button for save which will be enabled only when there are unsaved changes.
Remove Event.current.Use(); from StepsTreeView.KeyEvent() and add it to every implemented shortcut instead of global.
Optional improvement: Rewrite KeyEvent() to Shortcuts to allow changing shortcuts without code modifiaction