search

RockefellerArchiveCenter / styles

Style Library for the Rockefeller Archive Center
https://styles.rockarch.org
MIT License
0 stars 1 forks source link

Add tooltip component #180

Closed helrond closed 11 months ago

helrond commented 11 months ago

Adds tooltip component.

Also restructures the Travis config file to move steps related to deployment to the before_deploy stage so they will only run when necessary.

HaSistrunk commented 11 months ago

I made a few edits to the docs text - added some more best practices and the position classes that can be used.

Two questions:

  1. Should we mention that javascript is necessary to implement this? We do this in the dropdown component and maybe others, so I'm leaning yes for consistency and to quickly understand how to to implement.
  2. Do we want to expand the description to include tooltips that can be used on hover/focus?
helrond commented 11 months ago

Thanks for these edits!

To answer your questions:

  1. Yes! I meant to do that but blanked.
  2. That seems reasonable to me.