search

RockefellerArchiveCenter / styles

Style Library for the Rockefeller Archive Center
https://styles.rockarch.org
MIT License
0 stars 1 forks source link

Remove `select__label` and `select__control` classes from Select component #199

Closed helrond closed 5 months ago

helrond commented 6 months ago

Describe the bug

The select__label and select__control classes which are included in the Select component do not have corresponding styles, so they can be removed.

Expected behavior

Classes should either have styles associated with them, or should not exist.

Impact on your work

Minor bug, but good to get resolved before wider implementation of the RAC style library.

HaSistrunk commented 6 months ago

Do you have an opinion on if we should make our select component look more like the ones in DIMES? That is a custom components that we decided not to use in terms of HTML structure, but we could make them look like this (although we can't style the select options):

image

I don't see/recall why we just went with an unstyled select in the Style Library.

helrond commented 6 months ago

I don't recall either - it could be that unstyled options look weird in combination with the other styling. I wouldn't be opposed to some experimentation though.