search

RockefellerArchiveCenter / styles

Style Library for the Rockefeller Archive Center
https://styles.rockarch.org
MIT License
0 stars 1 forks source link

Adds Storybook header component #40

Closed helrond closed 3 years ago

helrond commented 3 years ago

This one is pretty complex. I've added stories for the following:

I suspect we'll have to tweak both the HTML and the styles for this as we implement.

Wondering if this should be a Header component instead of a Navbar? That's what we called it in DIMES...

fixes #19

HaSistrunk commented 3 years ago
  1. Yes, I vote to call this a header. Some of these iterations don't contain a nav, and header is an html element, whereas navbar evokes a Bootstrap header with navigation.
  2. I recently learned that apparently menu and menu-item are meant to be used specifically for an OS or application menu, not a nav, so I think we've implemented that incorrectly in DIMES (we used to also use role="menu" in rockarch.org, but moved away from that). I believe the "With Nav Items" component for mobile should follow our rockarch.org hamburger button pattern with an ul of navigation links.
helrond commented 3 years ago

Thanks for all the work on this @HaSistrunk!