Closed helrond closed 3 years ago
Yeah, this all looks good to me and the comments are a useful addition. I see that btn--transparent
is the only one without hover/focus styles (beyond the global focus styles that are defined outside of the component). This made me think about two things:
Adds styles for buttons. fixes #3
There are also a few other things in this PR:
material-icons
class tomaterial-icon
, which is more semantically correct. This has been documented in the change tracking document.btn--orange
currently does not meet the WCAG contrast threshold. This has been documented in the Known Issues section.