Add styles for card component

RockefellerArchiveCenter / styles

Style Library for the Rockefeller Archive Center

https://styles.rockarch.org

MIT License

0 stars 1 forks source link

Add styles for card component #76

Closed helrond closed 3 years ago

helrond commented 3 years ago

Adds styles for card component. A couple of notes:

The DIMES styles include CSS properties which set the width of the card. I have removed those here, since the number of cards in a row is likely to be a contextual decision.
Because we don't have a light-gray equivalent, I've just used a calculation for those values (box-shadow)
I've added very basic styles for a card-list. Curious what others think about this - does it make sense to consider the list an integral part of the component? The initial reason I did this was because Storybook was throwing an error because my li element wasn't contained in a ul or ol...

Fixes #57

HaSistrunk commented 3 years ago

I've added very basic styles for a card-list. Curious what others think about this - does it make sense to consider the list an integral part of the component? The initial reason I did this was because Storybook was throwing an error because my li element wasn't contained in a ul or ol...

I think this makes solid sense, because the list item will never be used without being part of a list (ul or ol). I don't think it should add confusion that when implementing, multiple lis go into one ul.

I'm curious about the use case of using an ol instead of a ul, though. Are you thinking of a particular context where this might be preferable?

helrond commented 3 years ago

I'm curious about the use case of using an ol instead of a ul, though. Are you thinking of a particular context where this might be preferable?

No, I don't think there's a reason to put these cards in an ol - I was just reporting the error Storybook gave me. I can't think of any use case where we'd want to have these in an ordered list...