Add styles for hero component

RockefellerArchiveCenter / styles

Style Library for the Rockefeller Archive Center

https://styles.rockarch.org

MIT License

0 stars 1 forks source link

Add styles for hero component #82

Closed bonniegee closed 3 years ago

bonniegee commented 3 years ago

Fixes #61

Adds the hero scss from DIMES
No changes made when copying from DIMES, though the line spacing (in the hero text) does not look correct to me--I'm not sure if this is an issue?
I added very minimal comments and would welcome feedback on what else would be useful to include in comments

helrond commented 3 years ago

No changes made when copying from DIMES, though the line spacing (in the hero text) does not look correct to me--I'm not sure if this is an issue?

I think there might be some styles for the typography in _typography.scss in DIMES. Initially we were putting all typography in one place, but that ultimately became more confusing than helpful as we got more components in place.

helrond commented 3 years ago

Looks good to me! I'm wondering if we should do away with the top margin on the .hero class? That seems variable depending on the context the component is used in, right?