RocketC31 / budget

Get a grip on your finances.
https://trackmybudget.org
MIT License
2 stars 0 forks source link

No flags shown anymore when selecting language #70

Closed sebastiaanspeck closed 1 year ago

sebastiaanspeck commented 1 year ago
image

The twemoji-flags.css is deleted in https://github.com/RocketC31/budget/commit/cccf7d11a7e2f8ef7e00148949d66bd8589a3500 but a reference still exists: <link rel="stylesheet" href="/twemoji-flags.css" /> in resources\views\app.blade.php

sebastiaanspeck commented 1 year ago

By opening this issue, question ourselves if we need flags, if so, revert deleting twemoji-flags.css otherwise, delete the reference to it in resources\views\app.blade.php

RocketC31 commented 1 year ago

Woops sorry, i have thinking it was not used anymore. The absence of flag does not bother me that said. What do you prefer you ?

sebastiaanspeck commented 1 year ago

In my opinion it's cleaner without flags, also since English used the American flag, but since we have British English and American English, this could be confusing

sebastiaanspeck commented 1 year ago

Also remove <i class="twf twf-s twf-' . $flag . '"></i> ' in SettingsController

RocketC31 commented 1 year ago

Thanks @sebastiaanspeck !