search

RocketC31 / budget

Get a grip on your finances.
https://trackmybudget.org
MIT License
2 stars 0 forks source link

After running `php artisan budget:install` my `yarn.lock` is updated #73

Closed sebastiaanspeck closed 1 year ago

sebastiaanspeck commented 1 year ago

See https://github.com/sebastiaanspeck/budget/commit/0d5aaef08845224d242e4ca72b30bee1a9699cb5 for the contents. Maybe we/you need to update the dependencies (and update composer as well)?

RocketC31 commented 1 year ago

Hmm... The yarn.lock file isn't supposed to stay locked until we perform a yarn update? Like with npm? I have the impression that it re writes following a yarn install in BudgetInstall.php

sebastiaanspeck commented 1 year ago

After running yarn install it doesn't update, but when using npm install it does update

RocketC31 commented 1 year ago

It's seem to be a know issue https://github.com/npm/cli/issues/5126 on npm

sebastiaanspeck commented 1 year ago

So the fix for now is to use yarn over npm

RocketC31 commented 1 year ago

Someone say

I mean, the workaround is just to restore the file with git restore yarn.lock after npm is run, but it gets boring.

We can maybe add on budgetinstall this restore if we select npm as package manager ?

sebastiaanspeck commented 1 year ago

Sounds like a good idea