search

RocketC31 / budget

Get a grip on your finances.
https://trackmybudget.org
MIT License
2 stars 0 forks source link

Migrate earnings and spendings to transactions table #80

Closed RocketC31 closed 1 year ago

RocketC31 commented 1 year ago

Hi @sebastiaanspeck i have worked on this issue.

I have change many many files. Initialy, we have say to use tinyint for type column on transaction table.

But, when i have start to do it. I noticied, on all other table, it's simple string... For not make this table the onlyone who have a tinyint for distinguish earning/spending. I have make exactly the same thing. Just add a string column. Not an enum.

I don't know if it's the best solution to make "like other table"... What's your opinion for that ?

Appart from that i have see, spendings and earning are used for activites / attachments. So i have make a migration with this consideration.

Same thing if you can review a little when you will have time, it will be more secure ! Thanks

sebastiaanspeck commented 1 year ago

This pull request is ready to merge. I've tested it using existing data.

RocketC31 commented 1 year ago

Thanks @sebastiaanspeck i have test too for apply and rollback with data. Thanks for your review !