RocketChat / Apps.Github22

The ultimate AI-powered app extending Rocket.Chat for global developers collaborating on Github (2024 and beyond)

33 stars 37 forks source link

[FIX]: Fix Share Issues Bug #132

Open VipinDevelops opened 6 months ago

VipinDevelops commented 6 months ago

Issue(s)

131

Description

It seems like the context.getInteractionData() always gives the general room as that is why we were facing weird issues in the code and a lot of features of our app are not working in channels other than general.

Acceptance Criteria fulfillment

[x] Fixed the Share issues in channel Bug
[x] Test that it works fine

Proposed changes (including videos or screenshots)

Screencast from 2024-02-28 00-06-23.webm

VipinDevelops commented 6 months ago

Hey @samad-yar-khan Can you please review these changes this is the but I mentioned in the public channel

samad-yar-khan commented 5 months ago

@VipinDevelops context.getInteractionData() shouldnt always return general, is this a bug in the Apps Engine ?

VipinDevelops commented 5 months ago

@VipinDevelops context.getInteractionData() shouldnt always return general, is this a bug in the Apps Engine ?

Yes @samad-yar-khan ,most probably. It's something to do with app engine, that's why I it took me some time fixing this. I will try to ask the app engine team to look into this.