Closed VipinDevelops closed 4 months ago
As a general comment, try keeping the writing style consistent - like variable names starting with lowercase letters unless globals, function names starting in lowercase as well. The styling looks out of place compared to other places of the codebase.
Idk where this repo stands on prettier or some kind of formatter, but would recommend using them.
I also noticed that most .app
repositories do have an tslint.json
however, there is no way to enforce it. I have created an issue for the same in Apps.Notion
: https://github.com/RocketChat/Apps.Notion/issues/74.
As a general comment, try keeping the writing style consistent - like variable names starting with lowercase letters unless globals, function names starting in lowercase as well. The styling looks out of place compared to other places of the codebase.
Idk where this repo stands on prettier or some kind of formatter, but would recommend using them.
Hey @debdutdeb,
You are correct, but @samad-yar-khan and I had a nice discussion about this matter. I even made a PR for the same. However, in the end, we decided to drop the plan and not add a lot of syntax changes, which might be hard to maintain. Although we do try to write all the code in the project in the same structure as much as possible. Let's discuss more about this in the channel.
Issue(s)
143
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)