feat: `/gh` alternative slash command to `/github`

RocketChat / Apps.Github22

The ultimate AI-powered app extending Rocket.Chat for global developers collaborating on Github (2024 and beyond)

33 stars 38 forks source link

feat: `/gh` alternative slash command to `/github` #24

Closed henit-chobisa closed 2 years ago

henit-chobisa commented 2 years ago

Issue(s)

Closes #23

Acceptance Criteria fulfillment

[x] Breaking Github Slash Command into several command utility methods, such as handleSingularParams, handleDualParams, parsed by main method, resolveCommand.
[x] Creating gh Slash Command class with typically implements Slash Command interface.
[x] Attaching the main command Utility class with the main slash command classes

Proposed changes (including videos or screenshots)

ghCommandSetup

Why this change ?

Actually I am a Github CLI user and I am kind of used to it, when I tried our app in Rocket Chat, I found that we should give another alternative to /github i.e. /gh which is also used by Github Cli and I believe, people will get used to it more quicker than /github.

samad-yar-khan commented 2 years ago

@henit-chobisa Can you please look into the merge conflicts : )

henit-chobisa commented 2 years ago

@henit-chobisa Can you please look into the merge conflicts : )

Sure, on it...

henit-chobisa commented 2 years ago

@samad-yar-khan Hey Samad, I have resolved the merge conflicts, it was about the deletions I made in the GithubSlashCommand.ts file, as I shifted all the imports and functions to the command utility.

samad-yar-khan commented 2 years ago

@henit-chobisa Thanks for the PR. I have tested the code. LGTM <3 . Can you please document your code changes, along with the new modules which you have introduced, so we can add them to the wiki so it becomes easier for future contributors to go through these changes.

henit-chobisa commented 2 years ago

@henit-chobisa Thanks for the PR. I have tested the code. LGTM <3 . Can you please document your code changes, along with the new modules which you have introduced, so we can add them to the wiki so it becomes easier for future contributors to go through these changes.

Thanks for the review Samad, I will try to make a notion doc and share with you, will that work?

samad-yar-khan commented 2 years ago

@henit-chobisa Thanks for the PR. I have tested the code. LGTM <3 . Can you please document your code changes, along with the new modules which you have introduced, so we can add them to the wiki so it becomes easier for future contributors to go through these changes.

Thanks for the review Samad, I will try to make a notion doc and share with you, will that work?

Works :) !!