Fixed Contribution Graph image URL

[chinma-yyy]

Issue(s)

Closes #53

Acceptance Criteria fulfillment

• [x] Display Contribution graph during sharing the profile
• [x] Display the contribution graph in the chat after sharing the profile

Proposed changes (including videos or screenshots)

Before

After

[samad-yar-khan]

@chinma-yyy thanks for the contribution and pointing this out. But this makes the project dependent on another project which may go down any moment leaving us with a buggy interface. What do you think @henit-chobisa ?

[chinma-yyy]

@chinma-yyy thanks for the contribution and pointing this out. But this makes the project dependent on another project which may go down any moment leaving us with a buggy interface. What do you think @henit-chobisa ?

Yes , @samad-yar-khan this was the original issue. Already in this File we were retrieving the graph from another project before but as it has been moved to another platform this issue was raised.Thank You.

[Nabhag8848]

@chinma-yyy thanks for the contribution and pointing this out. But this makes the project dependent on another project which may go down any moment leaving us with a buggy interface. What do you think @henit-chobisa ?

• ++1 @samad-yar-khan , I faced one similar issue in one of my project and did a trick. As the dependent project is MIT License we can publish that project in our cyclic account. Cyclic is free to use and anytime if that goes down we will have right and can manage to make it up again and we won't need to depend on them.

[samad-yar-khan]

@chinma-yyy thanks for the contribution and pointing this out. But this makes the project dependent on another project which may go down any moment leaving us with a buggy interface. What do you think @henit-chobisa ?

• ++1 @samad-yar-khan , I faced one similar issue in one of my project and did a trick. As the dependent project is MIT License we can publish that project in our cyclic account. Cyclic is free to use and anytime if that goes down we will have right and can manage to make it up again and we won't need to depend on them.

@henit-chobisa Since you introduced this, would like your opinion on it.

[Nabhag8848]

@chinma-yyy thanks for the contribution and pointing this out. But this makes the project dependent on another project which may go down any moment leaving us with a buggy interface. What do you think @henit-chobisa ?

• ++1 @samad-yar-khan , I faced one similar issue in one of my project and did a trick. As the dependent project is MIT License we can publish that project in our cyclic account. Cyclic is free to use and anytime if that goes down we will have right and can manage to make it up again and we won't need to depend on them.

@henit-chobisa Since you introduced this, would like your opinion on it.

Also to Note: Most probably changing deployment from heroku to cyclic would due to the heroku made thier service completely paid.

[samad-yar-khan]

@chinma-yyy @Nabhag8848 Tested the PR. I believe the project that we are using to render this is well maintained. If the URL changes in the future, some contributor will sure open and issue or we can host ourselves.

[chinma-yyy]

@samad-yar-khan The pr ready

[Nabhag8848]

@chinma-yyy @Nabhag8848 Tested the PR. I believe the project that we are using to render this is well maintained. If the URL changes in the future, some contributor will sure open and issue or we can host ourselves.

yep, @samad-yar-khan I believe we shouldn't host ourselves, Here is one Cons and Pros which i think we should note if we want to host ourselves:

Cons of Self-Hosting

• We will need that repo forked + we will need to sync the changes from main branch to our forked-main branch as soon as we can, for syncing we can use actions too like auto-sync-your-fork which upstream the forked repo with repo.

Pros of Self-Hosting

• We can have our own URL.

I see there are more Cons than Pros if we self-host also there would be more work around, We should avoid it if we can. cc @chinma-yyy