[BUG] missing i18n for english causing the description of command with extra removable string

RocketChat / Apps.Github22

The ultimate AI-powered app extending Rocket.Chat for global developers collaborating on Github (2024 and beyond)

33 stars 37 forks source link

[BUG] missing i18n for english causing the description of command with extra removable string #70

Closed Nabhag8848 closed 1 year ago

Nabhag8848 commented 1 year ago

Description:

When running any command /github, it shows the description of the command with the id of an App in form apps-<appid>-DESCRIPTION and the cause of the same is we don't have provided any i18n string of any language. Thus we need the i18n translation for english language for the Description and Params of command (i18nDescription && i18nParamsExample) under gh and github command class.

Steps to reproduce:

run `/github`
check the output with the description

Expected behavior:

Provide i18n for both, by creating folder i18n and naming the file en.json to resolve the issue

Actual behavior:

Screenshot from 2023-03-20 13-29-20

joe-shajan commented 1 year ago

So what will the end result look like?

Screenshot 2023-03-23 081834

What I'm assuming is instead of this id☝️ there must be something else. Am I right?

Nabhag8848 commented 1 year ago

So what will the end result look like?

What I'm assuming is instead of this idpoint_up there must be something else. Am I right?

Hey @samad-yar-khan do we need the description as "fetching github data" or we need changes? Can you provide the description and paramsexample string we need to have in translation. As i see @joeshajan is looking forward to contribute to rhis issue.

samad-yar-khan commented 1 year ago

@Nabhag8848 @joeshajan So, This should ideally include some short description of the app

Prince-Mendiratta commented 1 year ago

@samad-yar-khan @Nabhag8848 PR created to fix this, kindly review.