[FIX] helperMessage sending message instead of notification - Githubissues

RocketChat / Apps.Github22

The ultimate AI-powered app extending Rocket.Chat for global developers collaborating on Github (2024 and beyond)

33 stars 39 forks source link

[FIX] helperMessage sending message instead of notification #76

Closed Nabhag8848 closed 1 year ago

Nabhag8848 commented 1 year ago

Issue(s)

Closes #77

Proposed changes (including videos or screenshots)

Now helper message are sending as notification instead of message and not visible to all the user in room.

Approach/ Mindset when implementing

I have pass extra param as user (optional field )as basicQueryMessage is also being called when actionsbuttons generated from /github <username/repo>. thus user as optional as actionsbuttons would never lead to fire of helperMessage,
Reason for passing user not SlashCommandContext is in future we might need to add onInstallation we should get notify with helperMessage. Thus user not the CommandContext.

Nabhag8848 commented 1 year ago

Hey @samad-yar-khan , this PR is ready to review. Users would be seeing helper message run by other team members, we will need to fix this.