[Feat] Notification sent with `Login to Github` button when not authenticated

Prince-Mendiratta commented 1 year ago

Issue(s)

$ Fixes https://github.com/RocketChat/Apps.Github22/issues/47

Check for the following commands if the notification displayed has the "Github Login" button along with the message prompt to login.

[x] /github me
[x] /github subscribe
[x] /github Username/RepositoryName subscribe
[x] /github Username/RepositoryName unsubscribe
[x] /github issue
[x] ~/github issues~
[x] /github search

Proposed changes (including videos or screenshots)

Firstly, to keep code DRY and avoid repetition of code, I've created a separate method to create the Login ActionBlock. This method is reused in all places to create the action block. All the required commands will now directly show the Login to Github button, avoiding extra steps to authenticate.

Second important change is that in the Assign and Share Issues -> /github issues command, it will not work without authorization first. I added this because this was mentioned in the expected results by @Nabhag8848 in the linked issue.

Results

https://drive.google.com/file/d/1Cqe1dwObEMZ9fv0X_69O-a27icAhEjVR/view?usp=sharing

cc @samad-yar-khan @Nabhag8848

Prince-Mendiratta commented 1 year ago

gentle bump @samad-yar-khan

samad-yar-khan commented 1 year ago

@Prince-Mendiratta

/github issues works without auth aswell
/github search would also need this

Prince-Mendiratta commented 1 year ago

@samad-yar-khan

Reverted changes for /github issues. /github search already had the functionality, I missed out on that in the description. Added now.

RocketChat / Apps.Github22