Bug #73: Markdown render while listing all issues of repository

RocketChat / Apps.Github22

The ultimate AI-powered app extending Rocket.Chat for global developers collaborating on Github (2024 and beyond)

33 stars 37 forks source link

Bug #73: Markdown render while listing all issues of repository #82

Closed kanishbodhwani closed 1 year ago

kanishbodhwani commented 1 year ago

Issue(s) #73

Proposed changes (including videos or screenshots)

Markdown is fixed with all possible issues that can occur due to URL. Eg - Removed Square brackets , backticks and quotes.

Further comments

Removing all the occurrences of NOT-VALID URL characters.

CLAassistant commented 1 year ago

All committers have signed the CLA.

kanishbodhwani commented 1 year ago

@samad-yar-khan Please review this

kanishbodhwani commented 1 year ago

@Nabhag8848 Any suggestions ?

Nabhag8848 commented 1 year ago

Hey @kanishbodhwani Nice! but i think you mistakenly worked on main branch. Make sure you create new branch and work on that and open PR with branch you created.

samad-yar-khan commented 1 year ago

@kanishbodhwani , have we considered all cases for this ?

kanishbodhwani commented 1 year ago

@samad-yar-khan I'll check and if there is any case left I'll add that too

samad-yar-khan commented 1 year ago

@kanishbodhwani , I think we can maybe handle for cases where the Title has backticks (if they break the app) "FIX Modal" . Sample -> https://github.com/samad-yar-khan/dsa-problemset/issues/42

kanishbodhwani commented 1 year ago

@samad-yar-khan I've checked. This code is all we need to remove from a URL

samad-yar-khan commented 1 year ago

@kanishbodhwani Can this be extended to the method that sends the PR List to the channel ?