[bug] :Share profile modal closes on submit

RocketChat / Apps.Github22

The ultimate AI-powered app extending Rocket.Chat for global developers collaborating on Github (2024 and beyond)

33 stars 38 forks source link

[bug] :Share profile modal closes on submit #96

Open chinma-yyy opened 1 year ago

chinma-yyy commented 1 year ago

Issue(s)

closes #89

Acceptance Criteria fulfillment

[x] Added submit button to the modal
[x] Modal closing on submit

Proposed changes (including videos or screenshots)

Screencast from 01-04-23 12:46:23 AM IST.webm

Further comments

So here the share to chat button was an action button not a submit button so I moved the handler from action handler to view submit handler and also provided the submitted button to the view with the enum

chinma-yyy commented 1 year ago

Hey @samad-yar-khan I have raised the PR again . Its ready for review.

chinma-yyy commented 1 year ago

Hey @samad-yar-khan can you review this. This is a serious bug