[Bug] View Errors aren't working on any Modals when Field is Required and it closes the Modal Instantly

Nabhag8848 commented 5 months ago

What happened?

On Various Feature Modals, We Support ViewErrors if the Field is Required, but currently it doesn's show view Errors on UI and modal is getting closed.
Note that it happens on all Features supporting View Errors.

Steps to reproduce

For Eg:

[ ] Run /notion create
[ ] Do not input any Required Field.
[ ] Submit is closing Modal Instead of Showing ViewError in Search Page or Database Field.
[ ] ViewErrors Should Work on All Modals and Contextual Bar supporting for merging criteria.

Relevant ScreenShots

For eg: Similar to Following we support in this app:

https://github.com/RocketChat/Apps.Notion/assets/65061890/f9f05a70-0388-45a6-ab45-9b08a93da50b

Version

v6.5.3

What browsers are you seeing the problem on?

Chrome

umangutkarsh commented 5 months ago

Hey @Nabhag8848 . Would like to take this up. Thanks

Nabhag8848 commented 5 months ago

Awesome @umangutkarsh go ahead. 🚀

anjy7 commented 5 months ago

Hi @umangutkarsh, are you still working on this? If not then I would love to take a try on this :)

umangutkarsh commented 5 months ago

Hi @umangutkarsh, are you still working on this? If not then I would love to take a try on this :)

Hi @anjy7 , Will let you know, if I face any issues, we can both work on the same.

anjy7 commented 5 months ago

Sure, any update on the current progress? @umangutkarsh

Nabhag8848 commented 4 months ago

@Spiral-Memory I could find this on how ViewErrors Works. Watch out this GIF Carefully.

When comment button is pressed it shows validation. Currently Everything is working fine on our end.

Validation doesn't show up in UI. + In case of Modals, Modals get closed and doesn't show Validation UI in Elements.

Spiral-Memory commented 4 months ago

@Spiral-Memory I could find this on how ViewErrors Works. Watch out this GIF Carefully.

When comment button is pressed it shows validation. Currently Everything is working fine on our end.

Validation doesn't show up in UI. + In case of Modals, Modals get closed and doesn't show Validation UI in Elements.

Thanks for the info and your time finding this GIF. Sure, will see why this error appears and if i figure out something, i will mention that. 🚀

Nabhag8848 commented 4 months ago

@Spiral-Memory I could find this on how ViewErrors Works. Watch out this GIF Carefully. When comment button is pressed it shows validation. Currently Everything is working fine on our end.

Validation doesn't show up in UI. + In case of Modals, Modals get closed and doesn't show Validation UI in Elements. CommentOnPage

  [

      ![CommentOnPage](https://private-user-images.githubusercontent.com/65061890/309036815-626949f8-4fef-4735-bce4-83627fd0ac0e.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDkyMzI1OTksIm5iZiI6MTcwOTIzMjI5OSwicGF0aCI6Ii82NTA2MTg5MC8zMDkwMzY4MTUtNjI2OTQ5ZjgtNGZlZi00NzM1LWJjZTQtODM2MjdmZDBhYzBlLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjI5VDE4NDQ1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzZTkyZjc4MWQ0NTIxMjVkMTNmYmE2OTRiYWIxMTA4YTc1ZDExNWU2YTYyZDQyNDI0NTAwYzczNDAxZjg4ZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.hdPI7anu1-ZQcBJ3s6b3kvtxRt3bQUU9X5BhF0dcBpg)
    ](https://private-user-images.githubusercontent.com/65061890/309036815-626949f8-4fef-4735-bce4-83627fd0ac0e.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDkyMzI1OTksIm5iZiI6MTcwOTIzMjI5OSwicGF0aCI6Ii82NTA2MTg5MC8zMDkwMzY4MTUtNjI2OTQ5ZjgtNGZlZi00NzM1LWJjZTQtODM2MjdmZDBhYzBlLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjI5VDE4NDQ1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzZTkyZjc4MWQ0NTIxMjVkMTNmYmE2OTRiYWIxMTA4YTc1ZDExNWU2YTYyZDQyNDI0NTAwYzczNDAxZjg4ZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.hdPI7anu1-ZQcBJ3s6b3kvtxRt3bQUU9X5BhF0dcBpg)

    [

    ](https://private-user-images.githubusercontent.com/65061890/309036815-626949f8-4fef-4735-bce4-83627fd0ac0e.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDkyMzI1OTksIm5iZiI6MTcwOTIzMjI5OSwicGF0aCI6Ii82NTA2MTg5MC8zMDkwMzY4MTUtNjI2OTQ5ZjgtNGZlZi00NzM1LWJjZTQtODM2MjdmZDBhYzBlLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjI5VDE4NDQ1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzZTkyZjc4MWQ0NTIxMjVkMTNmYmE2OTRiYWIxMTA4YTc1ZDExNWU2YTYyZDQyNDI0NTAwYzczNDAxZjg4ZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.hdPI7anu1-ZQcBJ3s6b3kvtxRt3bQUU9X5BhF0dcBpg)

Thanks for the info and your time finding this GIF. Sure, will see why this error appears and if i figure out something, i will mention that. 🚀

@Spiral-Memory before that try this in CURRENT_LATEST_VERSIONof RocketChat Server + Check if this issue has been resolved or anyone has already found issue and workin on it. Confirm with Devanshu once.

PS: LOL We found a Bug in Github. 😂

Spiral-Memory commented 4 months ago

Sure @Nabhag8848

For that, i have to create a similar modal with the latest version right ? With View Error code in it.

GitHub bug : Yes it's unable to parse the reply properly 😂😂

Nabhag8848 commented 4 months ago

For that, i have to create a similar modal with the latest version right ? With View Error code in it.

@Spiral-Memory No, Just have a Latest version of RocketChat Server Up and Running, deploy and Test this notion app - Apps running on which version of Apps Engine doesn't matter. cause problem lies in Main Repo not Apps Engine Framework.

Spiral-Memory commented 4 months ago

The problem still exists @Nabhag8848 , I just tested it on the latest develop branch of RC app.

Well how are we sure that the problem lies in the main repo and not the engine ?

Nabhag8848 commented 4 months ago

@Spiral-Memory Check the Apps Engine Repo, You won't find any .tsx file cause. Cause We have bridge and convertor in Main Repo. In simple terms we have two system convertor lets us convert one data type to another so main core can understand and bridge allows two systems to talk to each other. all the implemetation is in Core - Packages.

For more: https://github.com/RocketChat/Rocket.Chat/tree/develop/apps/meteor/app/apps

Spiral-Memory commented 4 months ago

So ig mainly, i have to focus on the UiKit implementation.

@Spiral-Memory Yes I shared the exact line in rc check my message.

RocketChat / Apps.Notion