[ Fix ] Title Input Visibility When Nothing is Selected in Select Page Dropdown

Spiral-Memory commented 8 months ago

Issue(s)

Fixed the title input visibility issue; now it will be visible only when a page or database is selected (In the database, additional fetching happens, and that is left as it is).

Closes #52

Acceptance Criteria fulfillment

[x] Identified that the title block is rendered without any condition.
[x] Added an optional page argument, and the title block will be rendered only when a page or database is selected.
[x] Updated the modal when a page gets selected, similar to how it was implemented when a database is selected.

Proposed changes (including videos or screenshots)

Demo Video Link

Further comments

Spiral-Memory commented 7 months ago

@Spiral-Memory Added few comments. lets stick to standards. Will Merge this after I merge Sayan PR.

Overall LGTM

Sure @Nabhag8848, I have committed your suggestions. Thanks for the review and feedback. However, regarding the review, which formatter should we use to stick to the standards ?

Spiral-Memory commented 7 months ago

LGTM ! @Spiral-Memory 🚀, None Project already have prettier set up.

Okay @Nabhag8848 , Thanks for the input. will make sure to keep things formatted.

RocketChat / Apps.Notion