RocketChat / Apps.Notion

Integrating Notion with Rocket.Chat
https://github.com/Nabhag8848/Google-Summer-Of-Code
10 stars 20 forks source link

[Feat]: Add the ability to modify properties/schema of existing Notion databases #61

Open Spiral-Memory opened 10 months ago

Spiral-Memory commented 10 months ago

What do we need?

Currently, there is no option to add or delete properties of a Notion database after its creation. This option is only available during the database setup process. To modify the schema later, users must manually make changes within the Notion page itself, which can be inconvenient, especially when considering the benefits of integrations. The Notion API does offer functionality for property modification, which we can use to implement this feature.

Acceptance Criteria

Relevant ScreenShots

No response

Further Comments

No response

Spiral-Memory commented 10 months ago

@Nabhag8848 , I believe this feature would give users more control over their Notion databases within the Rc app. Please let me know if you also agree that this functionality would be valuable? If so, I'd be happy to begin working on its implementation.

Nabhag8848 commented 9 months ago

@Spiral-Memory There is much more priority feature we needed earlier, Updating the Record which is created in DB through Create Page or Record Modal.

lets say org is keeping track of project they are working on - in Notion Database and there is extension of project deadline, or it needs to assign to different person, xyz, etc. we can't do it currently which is needed and happens often.

Would you like to work on this right now or you want to stick to ViewErrors which you were working on ? , i can open a issue and provide all the details in issue on what we want? It will take lot of time to merge (like complete march) cause its huge ?

Nabhag8848 commented 9 months ago

@Spiral-Memory Also this limitation will make this feature [ modify Schema of DB ] more unusable.

This
Spiral-Memory commented 9 months ago

@Spiral-Memory There is much more priority feature we needed earlier, Updating the Record which is created in DB through Create Page or Record Modal.

lets say org is keeping track of project they are working on - in Notion Database and there is extension of project deadline, or it needs to assign to different person, xyz, etc. we can't do it currently which is needed and happens often.

Would you like to work on this right now or you want to stick to ViewErrors which you were working on ? , i can open a issue and provide all the details in issue on what we want? It will take lot of time to merge (like complete march) cause its huge ?

  • This Feature is Okay, but not so useful or priority, as this is not what user would use and need often, if you would think deeply, most of them won't prefer to use this even.

Sure, @Nabhag8848 , I understand. You can open the issue you are talking about along with ViewErrors. In parallel, I can try working on it. No problem if it takes time; if I can fix it, I will be happy to do so.

Yes, the feature I mentioned is not very useful. Maybe we can work on it later for the sake of making the Notion app more complete thats it.

Spiral-Memory commented 9 months ago

@Spiral-Memory Also this limitation will make this feature [ modify Schema of DB ] more unusable. This

Yep Actually, I tried doing this as well. I felt there are too many complexity to achieve it, have to take care of many cases, also the API had many limitation. Let's keep this issue open, after the priority features have been implemented, we may look into this at later stages

Nabhag8848 commented 9 months ago

@Spiral-Memory Also this limitation will make this feature [ modify Schema of DB ] more unusable. This

Yep Actually, I tried doing this as well. I felt there are too many complexity to achieve it, have to take care of many cases, also the API had many limitation. Let's keep this issue open, after the priority features have been implemented, we may look into this at later stages

https://youtu.be/8L_man2A1-M?feature=shared&t=76

Open the Modal with All the input Elements with initial value, similar modal we already have in create record feature right ? and update those fields which needed to be in one go in input elements the one which are not updated in the input fields doesn't matter cause we can make the request of changed value and default which wasn't changed and update the fields. this allows to make multiple fields change in one go.

What do you think ?

Spiral-Memory commented 9 months ago

Yes, @Nabhag8848 , you are correct. There can be cases when we want to update multiple things in one go. This ClickUp implementation will require updating things individually, which is not the best way. Yes, I have seen the create record implementation, and we can utilize a similar approach to implement this as well. My only concern, on which I am not sure, is whether the API we will be using supports receiving multiple data at once. I will go through that. The rest, I do agree with you.