search

RocketChat / Docker.Official.Image

Docker hub - community managed image
293 stars 218 forks source link

Docker hub repo -Which one is really official ? #112

Open jsalatiel opened 4 years ago

jsalatiel commented 4 years ago

There are https://hub.docker.com/_/rocket-chat?tab=tags and https://hub.docker.com/r/rocketchat/rocket.chat/tags. Which one is official docker repo? One seems to be twice bigger than the other.

aminvakil commented 4 years ago

Both.

https://github.com/RocketChat/Rocket.Chat#docker

https://hub.docker.com/_/rocket-chat is a release approved by docker team too, therefore it will be always older (from my experience about two weeks) than the rocketchat official one.

But interesting point you've mentioned about size, I don't know either.

jsalatiel commented 4 years ago

@sampaiodiego Do you know why the size is different ?

jsalatiel commented 4 years ago

One thing that I also have noticed is that one of the repos has a much more vulnerable image when scanned by Clair. 3.2.2 is the one approved by docker team. image

sampaiodiego commented 4 years ago

@sampaiodiego Do you know why the size is different ?

the size difference is because they are built from very different Dockefiles (docker official and rocket.chat). the same applies to vulnerabilities as they depend on different base images.

we've discussed a few times if we should have only one Docker image.. the main issue is that sometimes we want to published "special images" or images used for testing purposes, in this cases the "official docker" images are not suitable for.

I'll at least try to use a more close Dockerfile for both images, it will reduce the differences (either in size and vulnerabilities) between them and also help maintainability 👍