RocketChat / Docker.Official.Image

Docker hub - community managed image
291 stars 217 forks source link

Fix invalid traefik label #163

Closed srsbzns closed 2 years ago

srsbzns commented 2 years ago

Previous label does not appear to conform to Traefik's documented labels:

https://doc.traefik.io/traefik/reference/dynamic-configuration/docker/

This results in the traefik container attempts to fetch a certificate for something other than the hostname declared in ${DOMAIN}:

redacted-chat-traefik-1  | time="2022-06-28T22:20:44Z" level=error msg="Unable to obtain ACME certificate for domains \"rocketchat-redacted-chat\": unable to generate a certificate for the domains [rocketchat-redacted-chat]: acme: error: 400 :: POST :: https://acme-v02.api.letsencrypt.org/acme/new-order :: urn:ietf:params:acme:error:rejectedIdentifier :: Error creating new order :: Cannot issue for \"rocketchat-redacted-chat\": Domain name needs at least one dot" ACME CA="https://acme-v02.api.letsencrypt.org/directory" routerName=rocketchat@docker rule="Host(`rocketchat-redacted-chat`)" providerName=acmedns.acme

Updating the label to conform to Traefik's documentation appears to resolve the issue and result in the expected behavior.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.