Fix base image for ARM support

RocketChat / Docker.Official.Image

Docker hub - community managed image

305 stars 215 forks source link

Fix base image for ARM support #54

Closed khasim closed 5 years ago

khasim commented 6 years ago

While trying to build Rocket.chat for ARM64 we found the Fibers package missing. There is a pre-built Fibers package for x64, but it has to be built from source on arm64. However, the build fails with -slim node image from which some tools like python are missing.

Therefore we request the Rocket.chat project switch to using the non slim version of node image.

The issue was reported earlier here : RocketChat#48

CLAassistant commented 6 years ago

All committers have signed the CLA.

khasim commented 6 years ago

Hello, can some one kindly review the PR ? Is there any better way to achieve this ? I mean support for ARMv8 ? I tried to add delta packages on top of slim base image but that doesn't fetch packages like Python etc for ARMv8.

lag-linaro commented 5 years ago

This is not the right approach. I shall follow-up with a PR to superseded this.

Please close it for now.

lag-linaro commented 5 years ago

Submitted #60 to supersede this PR.

@khasim (or one of the project maintainers) could you please close this?

lag-linaro commented 5 years ago

Could someone please close this PR?

Sing-Li commented 5 years ago

Yes. I will close this. See the currently working approach to build here:

https://github.com/RocketChat/Rocket.Chat.Embedded.arm64/tree/develop/docker

lag-linaro commented 5 years ago

Why have you created a new project instead of making this one multi-arch?