update Docker's "MAINTAINER" instruction

RocketChat / Docker.Official.Image

Docker hub - community managed image

295 stars 218 forks source link

Closed knrt10 closed 5 years ago

knrt10 commented 5 years ago

This PR updates Docker's "MAINTAINER" instruction as it is deprecated.

Fixes #69

cc @Sing-Li would you please review.

CLAassistant commented 5 years ago

All committers have signed the CLA.

geekgonecrazy commented 5 years ago

You can’t simply switch to the alpine base. When you start it things like sharp will break.

Also that tag isn’t available for us to depend on. Which is why our current image is currently behind.

knrt10 commented 5 years ago

So should I change it back, and just let the MAINTAINER be updated? Although docker image was running fine. cc @geekgonecrazy

knrt10 commented 5 years ago

@geekgonecrazy updated the PR, please review

geekgonecrazy commented 5 years ago

Although docker image was running fine.

Please see the alpine PR in our main repo for an example of the trickery required :)

Will take a look at update!

geekgonecrazy commented 5 years ago

Thanks for the contribution