Improvements on SearchMessage.js

RocketChat / EmbeddedChat

An easy to use full-stack component (ReactJS) embedding Rocket.Chat into your webapp

https://rocketchat.github.io/EmbeddedChat/docs

115 stars 231 forks source link

Improvements on SearchMessage.js #148

Closed honey-grapes closed 1 year ago

honey-grapes commented 1 year ago

While looking through issue #132 I found some things in SearchMessage.js that could be improved upon. Please let me know if you agree and I can start working on them:

[ ] e.keyCode = 13 is deprecated according to MDN.
[ ] There are a couple of inline functions which is usually not great for performance For the inline functions, please let me know if I should change them for the other ones I see in other files?

Thanks!

VenomFate-619 commented 1 year ago

many functions are written in JSX directly, they should be outside.

source:- ChatInput.js

The function inside onChange and onKeyDown should be outside, so that code remains clean @sidmohanty11

sidmohanty11 commented 1 year ago

@honey-grapes @VenomFate-619 Yup! These improvements will be huge for improving our code quality! Thanks!

VenomFate-619 commented 1 year ago

@honey-grapes maybe we can collaborate on it to make the code clean. We can develop a doc regarding the coding standard and practices.

raazseth commented 1 year ago

Can I work on this issue? Please assign me @sidmohanty11

umangutkarsh commented 1 year ago

Hi @sidmohanty11 , if this issue has not been resolved, please assign this to me.

umangutkarsh commented 1 year ago

Hi @sidmohanty11 , I've created a pull request for the improvements in SearchMesage.js. Please provide your feedback if I should proceed with the changes in the inline functions in other files.