search

RocketChat / EmbeddedChat

An easy to use full-stack component (ReactJS) embedding Rocket.Chat into your webapp
https://rocketchat.github.io/EmbeddedChat/docs
125 stars 251 forks source link

Disproportionate Emoji Size in Reaction Count Button #266

Closed abhinavkrin closed 1 year ago

abhinavkrin commented 1 year ago

Description:

The emoji used in the reaction count button appears significantly larger than the accompanying count number, resulting in a visual inconsistency.

Steps to reproduce:

  1. React to a message if the message does not have any reaction yet.

Expected behavior:

screenshot_expected

Actual behavior:

reaction-emoji-toobig

wrth1337 commented 1 year ago

I would like to work on this issue @abhinavkrin

abhinavkrin commented 1 year ago

Hey @wrth1337 Thank you! I have assigned it you.

wrth1337 commented 1 year ago

I have a fix but it uses the deleted Markdown.css from #262 . At this point, you should first get the "Markdown.styles.js" file running.

Jenil-Dobariya commented 1 year ago

Hi @abhinavkrin , I want to know if this issue is fixed or not. I can give a try to resolve this if not already.

noothiakshith commented 1 year ago

Hi @abhinavkrin , i have started working on this issue as, this is first contribution if it is not assigned ,kindly assign to me . I can make my effort to fix this incase if not already

Rohit-Sharmaa commented 1 year ago

@noothiakshith are you working on this issue ??

abhinavkrin commented 1 year ago

Hey @Rohit-Sharmaa could you fix this. I will be happy to merge your fix.

Shubham071122 commented 1 year ago

Hey @abhinavkrin are you working on this issue, if not can you assign me i give a try.

tj8016 commented 1 year ago

To solve this issue, I set up this project locally I follow all the instruction, All command are running fine but on packages/api when i run yarn dev terminal giving me error Usage Error: Couldn't find a script named "parcel".

Screenshot 2023-11-13 at 11 30 51 PM Screenshot 2023-11-13 at 11 29 59 PM

How can i deal with this issue ?

abhinavkrin commented 1 year ago

Hey @tj8016 You need to first run yarn in the EmbeddedChat directory which will install and build the required packages.

abhinavkrin commented 1 year ago

Hey @Shubham071122 Thanks. Surely you can create a fix PR for this issue.

tj8016 commented 1 year ago

Hey @tj8016 You need to first run yarn in the EmbeddedChat directory which will install and build the required packages.

I run yarn in the EmbeddedChat directory but did not worked. After checking the package.json of packages/api directory i found the parcel devDependencies not installed, I install it and it is working now.

tj8016 commented 1 year ago

I want to work in this issue