[Accessibility] : Ability to toggle Password Visibility

RocketChat / EmbeddedChat

An easy to use full-stack component (ReactJS) embedding Rocket.Chat into your webapp

https://rocketchat.github.io/EmbeddedChat/docs

125 stars 251 forks source link

[Accessibility] : Ability to toggle Password Visibility #369

Closed Akshun-01 closed 10 months ago

Akshun-01 commented 11 months ago

As an EmbeddedChat developer

I need to: I think we should add the eye icon to toggle the encryption of password (which is very common in a lot of logging in interfaces.) currently it looks like this

So That: Adding the eye icon, will be helpful if anyone mistypes the password or want to double check rather than typing the password again from zero Acceptance Criteria

[x] Add the eye icon (make sure its responsive)
[x] Add the toggling logic to it

Akshun-01 commented 11 months ago

I would really like to work on this issue, if maintainers find it to be something that needs attention!

Akshun-01 commented 10 months ago

Further Improvemnets that can be implemented on Login:

Error Modal to check for Incorrect or Empty fields
Using Enter key in addition to the Login Button

What are your thoughts on this ? @umangutkarsh @Yashraj7890