search

RocketChat / EmbeddedChat

An easy to use full-stack component (ReactJS) embedding Rocket.Chat into your webapp
https://rocketchat.github.io/EmbeddedChat/docs
112 stars 222 forks source link

Test out starring and pinning of messages on RC v5+ #49

Open sidmohanty11 opened 1 year ago

sidmohanty11 commented 1 year ago

Description: Users don't join the channel when they get authenticated using Google SSO.

Steps to reproduce:

  1. Login into EmbeddedChat using Google SSO
  2. Notice that you are able to message
  3. Message in the channel
  4. Go to the RC server and see that the user isn't a member of that channel

Expected behavior:

User should automatically become a member of the channel when he/she messages into the channel

Actual behavior:

It isn't the case, but user can still message

sidmohanty11 commented 1 year ago

Still an issue for RC server v5+ (checked out with v5.1.0)

vishakha-aggarwal commented 1 year ago

Hey, I want to work on this issue, can you please assign it to me?

sidmohanty11 commented 1 year ago

Hey @vishakha-aggarwal , actually we want this to be implemented in RC backend only and we don't want to make a separate API call.

Link to the issue in RC: https://github.com/RocketChat/Rocket.Chat/issues/26266

I think there are some PRs made regarding this issue but feel free to check them out.

PS - We are making 3 API calls when we sign up, so we don't want to increase it.

vishakha-aggarwal commented 1 year ago

Thank you, I will definitely check them.

Yashraj7890 commented 9 months ago

Hey @sidmohanty11 is this issue still up, if it is I would like to work on it can it be assigned to me if that's the case.