RocketChat / EmbeddedChat

An easy to use full-stack component (ReactJS) embedding Rocket.Chat into your webapp

https://www.npmjs.com/package/@embeddedchat/react

107 stars 214 forks source link

fix: infinite render and console errors due to search component #503

Closed Spiral-Memory closed 4 months ago

Spiral-Memory commented 4 months ago

Brief Title

I have observed some minor bugs introduced by PR #497 , and this PR is intended to address these issues of infinite renders and console errors as quickly as possible

Acceptance Criteria Fulfillment

[x] Resolved infinite renders
[x] Resolved console error related to SVG size

Fixes #502

Video/Screenshots

https://github.com/RocketChat/EmbeddedChat/assets/78961432/9430f9e8-cc01-4396-8f12-90bd17e51e2b

Spiral-Memory commented 4 months ago

Hey @sidmohanty11 , there is a minor bug introduced after recent merge #497 while rendering the search component. It was rendering infinitely. I have tried fixing it. Please review this as early as possible.

JeffreytheCoder commented 4 months ago

@Spiral-Memory Thanks for spotting this 👍

Spiral-Memory commented 4 months ago

@Spiral-Memory Thanks for spotting this 👍

No worries, bro 😃! We are here to help each other.