RocketChat / EmbeddedChat

An easy to use full-stack component (ReactJS) embedding Rocket.Chat into your webapp
https://www.npmjs.com/package/@embeddedchat/react
107 stars 214 forks source link

fix: centered throbber, added fallback, set default closable false #540

Closed Spiral-Memory closed 3 months ago

Spiral-Memory commented 3 months ago

Brief Title

Aligned the throbber in the image gallery and fixed infinite loading even when image fetching fails in the newly added image gallery (The same is implemented in RC as well)

Separately, in relation to another issue: isClosable is set to true in story examples, causing confusion. It should only be enabled when the true prop is explicitly passed along with a proper setClosable function, rather than just a boolean value (which was causing errors in the console). To avoid confusion, I have set setClosable as false by default and am passing an empty function.

Acceptance Criteria Fulfillment

Fixes N.A

Video/Screenshots

Before:

image

image

https://github.com/RocketChat/EmbeddedChat/assets/78961432/1e11cd83-5b6b-4a6a-baff-115f725b8e93

After:

image

image

https://github.com/RocketChat/EmbeddedChat/assets/78961432/54e605e7-3395-4c42-9878-467b2b8b75fa