RocketChat / EmbeddedChat

An easy to use full-stack component (ReactJS) embedding Rocket.Chat into your webapp
https://www.npmjs.com/package/@embeddedchat/react
107 stars 214 forks source link

feat: addition of curve design variant with customization options #581

Closed Spiral-Memory closed 1 month ago

Spiral-Memory commented 1 month ago

Brief Title

Acceptance Criteria Fulfillment

Fixes #580

Video/Screenshots

https://github.com/RocketChat/EmbeddedChat/assets/78961432/ec02fdbc-285d-43a2-b0d4-bce5f9d0b2cd

https://github.com/RocketChat/EmbeddedChat/assets/78961432/06d61e66-8f17-423b-a339-1728323661b3

Spiral-Memory commented 1 month ago

Hey @sidmohanty11

This PR is now ready for review. I've fixed some bugs and made the menu customizable based on our discussion. Now, developers can pass the name of the option they want to keep in the theme object, and the other options will be automatically removed. If someone wants to wrap those options into a menu, they could pass a threshold, and the other options will be wrapped inside the menu.

Additionally, I've introduced the bubble variant in this PR. In each case, I've ensured that the display of attachments, thread reply button, quoting, or pinning the message matches the bubble variant.

The entire change is also explained in the attached video. Kindly review this PR. This was to add the variant for ChatBody. For Chat Input and Sidebar, I will also add variants in upcoming PRs, such as the Discord look, as per our discussion.

Thanks!

Spiral-Memory commented 1 month ago

Too good! This is awesome! Lets refactor this a bit in your next PR. LGTM!! 💯 🏆

Thank you so much, @sidmohanty11 , for the appreciation! Glad you liked it! I'll make the necessary changes in the next PR.