RocketChat / EmbeddedChat

An easy to use full-stack component (ReactJS) embedding Rocket.Chat into your webapp
https://rocketchat.github.io/EmbeddedChat/docs
125 stars 251 forks source link

Bug: Error Pinning the Message #639

Closed ghost closed 1 month ago

ghost commented 1 month ago

Description:

When I am clicking on Pin icon to pin my message it's showing an error.Its showing error pinning the message.Look at the video that I had shared for more consice info.

Expected behavior:

The expected behaviour should be my messages will got pinned on clicking on the pin icon

Actual behavior:

But it's actually returning an error.

https://github.com/user-attachments/assets/77e1c2fa-7081-418e-9174-0ce5d9b5169d

devanshkansagra commented 1 month ago

Hey @yours-majesty, there is no point of raising this issue, the pinning and unpinning of messages is handled by admin of Rocket chat server so non-admin users cannot pin-unpin the messages.

My admin Login in my RocketChat Server:

image

My Non admin login in my RocketChat server

image

If you look closely there is an option of pin in the admin part and it is not there in non-admin part.

@Spiral-Memory and other maintainers of this project Please share your points also so that I can get to know whether I am correct or not

Spiral-Memory commented 1 month ago

@yours-majesty @devanshkansagra

Refer to this issue : https://github.com/RocketChat/EmbeddedChat/issues/519

devanshkansagra commented 1 month ago

Yea @Spiral-Memory That also I observed that there is unwanted visiblity of pin icon on non - admin users side in the EmbeddedChat

Spiral-Memory commented 1 month ago

Yeah, One of you or collaboratively work on it if you want or you can review the already raised PR and see if it is fine or modifications are needed

devanshkansagra commented 1 month ago

I am reviewing it that pr and @yours-majesty you can also join and start your Open Source Contribution journey