[IMPROVE] refactor hard-coded component data into parameters (react component props)

RocketChat / RC4Community

Full-stack components for building, engaging, and growing your massive on-line community

https://community.rocket.chat/

Apache License 2.0

48 stars 68 forks source link

[IMPROVE] refactor hard-coded component data into parameters (react component props) #145

Open nishant23122000 opened 2 years ago

nishant23122000 commented 2 years ago

Put all Hardcoded content outside of component in app/data folder and improved the responsiveness of Infotiles and carousel component by adding media query.

Reference : #77

CLAassistant commented 2 years ago

All committers have signed the CLA.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 1 when merging 21704ff22eef9741f23e426f1aa5b7947a0645ba into 6dbe41cf18d05d34789e63b3ba8fe56a87ef812e - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging d77d437831d3cba3f9e27de3851ceb32aa81538c into 65fbcd38e10dc252743dc25693218c2982db3ebc - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

nishant23122000 commented 2 years ago

RocketChat / RC4Community

[IMPROVE] refactor hard-coded component data into parameters (react component props) #145

1. added counters,infotiles,discourse json files inside initialData. so when user set INITIALIZE_DATA=true,it will add data into strapi collections.