[NEW]Abstract the NFT upsert

RocketChat / RC4Community

Full-stack components for building, engaging, and growing your massive on-line community

https://community.rocket.chat/

Apache License 2.0

49 stars 68 forks source link

[NEW]Abstract the NFT upsert #157

Closed Dnouv closed 2 years ago

Dnouv commented 2 years ago

This PR is a step towards the abstraction of Superprofile.

lgtm-com[bot] commented 2 years ago

This pull request introduces 8 alerts when merging 9749339ca63fac067a1de8180c00e56ec0fe2afa into d5b01dda616313440a287c13a0031cef86890a25 - view on LGTM.com

new alerts:

7 for Unused variable, import, function or class
1 for Missing variable declaration

Sing-Li commented 2 years ago

This PR is a step towards the abstraction of Superprofile.

Awesome! Thanks for starting this. Please keep in mind that superprofile should just track "globally available key value pairs" - like a noSQL database, but with limited query capabilities and already-world-scaled scope.

It should not, for example, have any knowledge of NFTs --- therefore it should not and can never have an NFTUpsert method. Instead perhaps .... transactionalUpdateInsert( "nftaddr", "xxxxxxxx")

Dnouv commented 2 years ago

Closing in view of #169

Thanks!