[NEW] dummy auth model - Githubissues

RocketChat / RC4Community

Full-stack components for building, engaging, and growing your massive on-line community

https://community.rocket.chat/

Apache License 2.0

49 stars 68 forks source link

[NEW] dummy auth model #171

Closed sidmohanty11 closed 2 years ago

sidmohanty11 commented 2 years ago

This PR introduces,

[x] a dummy authentication model
[x] removes firebase error
[x] fixes all the console errors for a smooth development experience

Fixes #156

sidmohanty11 commented 2 years ago

Dummy User Authentication Model

https://user-images.githubusercontent.com/73601258/174348400-90d4baa5-4026-4e1f-9fe5-8851cddff741.mp4

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging c09a95e526c8037275d1eeb46bf27a86673bc624 into 13b5926cfb2029af283bf95bc6995f41fa1ffd73 - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging 65256352ac6241e68a66324bf887b926daecc542 into b14261054bac8c88eb74685f7759fa87aa8b7bbf - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

sidmohanty11 commented 2 years ago

I've fixed almost all errors that were arising:

firebase error
slideCount error

There remains only one error (<button> inside <button>) which is coming from the Menubar component because we are using Navbar.Toggle but inside for styling, we are using another button. This should be fixed with the new Menubar component which is being worked on in this PR.

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging f96a1d5a0a61fd6db404236c28a65fd09cb1757a into 53d9c3d95e5a8b872da8fb373509d222d8260186 - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

sidmohanty11 commented 2 years ago

It is there in my case.

Is it due to cms uninitialized? But that should break the app, right? Can you check with running cms?

Sing-Li commented 2 years ago

cms definitely initialized - otherwise there will be no element live. can you verify with a clean clone? I think you may have something added that has not been committed or initialized? @sidmohanty11 thx

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging fdfcf4c1645d1a10c55eaee83e151631a1e70c94 into 53d9c3d95e5a8b872da8fb373509d222d8260186 - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

sidmohanty11 commented 2 years ago

Did a clean clone and install, the top nav works for me.