[NEW] Eslint and prettier configs with husky pre-push hook

RocketChat / RC4Community

Full-stack components for building, engaging, and growing your massive on-line community

https://community.rocket.chat/

Apache License 2.0

48 stars 68 forks source link

[NEW] Eslint and prettier configs with husky pre-push hook #174

Closed sidmohanty11 closed 1 year ago

sidmohanty11 commented 2 years ago

Added Eslint configs and checks to both app and cms
Added Prettier configs to format code to both app and cms
Added husky pre-push hook to format and lint code before pushing the code

Closes #172

debdutdeb commented 2 years ago

Hey @sidmohanty11 please remove the hook. thanks.

debdutdeb commented 2 years ago

Why not put the configs on the top level?

sidmohanty11 commented 2 years ago

@debdutdeb we can't do it with eslint as its configs are different for app and cms, but as far as I know, prettier will go up one dir and search for the config till it finds one, so we can definitely use it from the top level. I've made the changes, please let me know if something else needs to be changed.

Thanks!

Palanikannan1437 commented 1 year ago

@Sing-Li @Dnouv and @sidmohanty11, has all of this been addressed in resolved in #189?