search

RocketChat / RC4Community

Full-stack components for building, engaging, and growing your massive on-line community
https://community.rocket.chat/
Apache License 2.0
48 stars 68 forks source link

Tons of linting error in `app` directory #175

Closed sidmohanty11 closed 1 year ago

sidmohanty11 commented 2 years ago

These linting errors need to be fixed!

image

msabirz commented 2 years ago

Should I take it up?

sidmohanty11 commented 2 years ago

@msabirz sure

msabirz commented 2 years ago

Pls assign it to me

sidmohanty11 commented 2 years ago

@msabirz I'm sorry, I am not capable of doing that. @debdutdeb @Sing-Li can you help?

msabirz commented 2 years ago

Ok pls do the needful

msabirz commented 2 years ago

I am taking this

debdutdeb commented 2 years ago

Alright @msabirz pls communicate any concerns or questions on our contributors channel. This is a very crucial task, I was going to take it on, thanks for volunteering.

msabirz commented 2 years ago

sure @debdutdeb

sidmohanty11 commented 2 years ago

@msabirz FYI, this is our contributors channel -> https://open.rocket.chat/channel/contributors

msabirz commented 2 years ago

Thanks

Sing-Li commented 1 year ago

@Palanikannan1437 seems @msabirz has dropped the ball. Do you think you can take this (should be straightforward and simple) task on?

Basically npm run lint should be clean. under both app and cms - thanks.

Palanikannan1437 commented 1 year ago

@Palanikannan1437 seems @msabirz has dropped the ball. Do you think you can take this (should be straightforward and simple) task on?

Ohh yeah sure! I'll do this before #184 then

Sing-Li commented 1 year ago

sure :pray: #184 can take a while. This one doesn't require a fast Internet at all 🙂 🙏

Palanikannan1437 commented 1 year ago

Sure thing!

Yup...ouch the internet thing still hurts🙃

Could you please assign it to me @Sing-Li