search

RocketChat / RC4Community

Full-stack components for building, engaging, and growing your massive on-line community
https://community.rocket.chat/
Apache License 2.0
48 stars 68 forks source link

[TODO] Extend Rocket.Chat Auth for Google Auth to support Github Auth #185

Open Sing-Li opened 1 year ago

Sing-Li commented 1 year ago

Using the existing "Rocket.Chat Auth for Google Auth Component" as a framework, add support for the following Rocket.Chat auths:

The existing component should be extended, instead of new components created -- since they're all Rocket.Chat auths.

(it may be a good idea to keep each supported auth as a sub-component/plugin of the auth - hence using it as a framework)

Nabhag8848 commented 1 year ago

Hey @Sing-Li, i would like to work on this issue can you assign it to me. I will start right away😄

Dnouv commented 1 year ago

Hey @Nabhag8848

Thank you for taking up the issue. However, you would have to implement this in RC4Conferences first and then backport it to RC4Community; RC4Conferences can be considered as a beta testing ground for the new components. And please do explain the approach you will be taking for this issue on RocketChat/RC4Conferences#42 this can in a way be good for refining your solution by the community.

If you have any doubts, please feel free to ask them right away. Thank you!