FIX : Cleaned up components by parameterising

RocketChat / RC4Community

Full-stack components for building, engaging, and growing your massive on-line community

https://community.rocket.chat/

Apache License 2.0

48 stars 68 forks source link

FIX : Cleaned up components by parameterising #196

Closed Palanikannan1437 closed 1 year ago

Palanikannan1437 commented 1 year ago

Closes #195

Issue in brief

Some components weren't fully parameterised to be used as customisable components in pages

Suggested Fixes/Changes

parameterised newMenu and added option to choose brand information at the root level

Palanikannan1437 commented 1 year ago

@Dnouv please let me know if further components are to be parameterised and if I've missed out on something. I'm a bit confused if we want anything else to be parameterised 😅

(I haven't gone through Jitsi related components yet, will do that asap)

Thank you!

Dnouv commented 1 year ago

Thank you for the hard work! Yes, this is all good till now; great work! The forms component was remaining, but I guess it is already parameterized at the page level.

Palanikannan1437 commented 1 year ago

Thank you for the hard work! Yes, this is all good till now; great work! The forms component was remaining, but I guess it is already parameterized at the page level.

Ohh yeah I did go through the forms, they already seemed parameterized😄