Closed muneeb-i-khan closed 1 year ago
Palanikannan1437 You can check it now.
@muneeb-i-khan
Awesome job on explaining the PR with all the screenshots and gifs π!
Please refrain from changing the default styles of our component drastically(height, width, etc)...it was by design and well thought of by our contributors, please try to fix the responsiveness while keeping the current styles intact! Thank you! π
Okay I will try itπ
@Palanikannan1437 I restored all the default styles at places where it was possible. Tell me if there are any other changes required.
This fixes the following issue:- https://github.com/RocketChat/RC4Community/issues/205
Hey @muneeb-i-khan, it's still not close to our previous design and doesn't seem like an improvement either and is oddly spaced out according to me...would be awesome if you could keep the existing design while making it responsive as suggested above as well!
Before your changes:
After your changes:
@Sing-Li @Dnouv @irffanasiff would be able to guide better here, thank you! π
Is it fine now or I need to make more changes? @Palanikannan1437
Is it fine now or I need to make more changes? @Palanikannan1437
Hey, it still doesn't keep the original changes... this was closed in this
Please consider closing this issue @muneeb-i-khan ....
Would love to see your contributions on the other open issues!! Thank you ππ
So I have fixed the responsiveness of news carousel section. Also I have made styles consistent.
First fix was making the styles consistent and you can check the results below:-
Before
After
Second fix was making the section responsive. Earlier the text flowed outside the image. You can check the results below:-