search

RocketChat / RC4Conferences

A set of scalable components for communities to build, manage, and run virtual conferences of any size.
https://conf.rceng.shop/conferences/c/1
24 stars 39 forks source link

TODO: Add Code Format Standards - Prettier, Lint #109

Closed Dnouv closed 1 year ago

Dnouv commented 1 year ago

Introduce new prettier, and lint standards for the project, and whenever the user pushes their commit, make sure they have already in compliance with the standards

VipinDevelops commented 1 year ago

Hey, @Dnouv I would like to work on this issue and introduce a new standard for code formatting and linting in our project. We will be using Prettier and Lint to ensure consistent and clean code across the entire project.

I have the necessary skills and experience to ensure that our codebase is consistently formatted and lined, which will make it easier for everyone to understand and maintain.

I understand that this task requires ensuring that all future code changes are in compliance with the new standards before they are committed. I am committed to taking the necessary steps to ensure that this process is as seamless and efficient as possible.

Please let me know if this is something you would like to assign to me.

Thank you!

VipinDevelops commented 1 year ago

To solve this issue

  1. I will Start by adding the necessary dependencies such as Prettier and a linting library like ESLint to your project.
  2. Then I will Set up the configuration files for both Prettier and the linting library.
  3. Will Create a pre-commit hook using tools like Husky or pre-commit. This hook will run the Prettier and linting checks before allowing a commit.
VipinDevelops commented 1 year ago

https://github.com/RocketChat/RC4Conferences/pull/111 Have a look at the changes i made here in this PR and do let me know if any changes required

Dnouv commented 1 year ago

Hey @VipinDevelops

Thank you so much for your interest. I would suggest not starting working on this since you are already working on #66 once you figure out a solution for it, and we have your PR merged for it, only then you should take up this issue. This will cause other new coming contributors to lose issues to work on. I hope you understand this message.

Thanks!

thapar-vansh commented 1 year ago

Hey @Dnouv , if @VipinDevelops is busy on some other issue I can take on this one . I have prior experience with prettier and ES Lint as well . Can you please describe the linting rules you wanna implement ? Thanks !

Dnouv commented 1 year ago

Sorry but closing this issue as not planned; we will open this issue once we have an active developers community. Thank you so much for all your interest; please take up the issues with the milestone tag.